Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the versions of various libraries in the repository, as reflected in .librarian/state.yaml, CHANGELOG.md, and librarian.yaml. The review identified that the CHANGELOG.md file contains unsorted entries, likely due to an issue in the automated generation tool. Additionally, it was noted that the removal of a comment in librarian.yaml regarding skip_release for google-cloud-bigtable should be addressed by documenting the reasoning in config.yaml instead, as comments are not preserved in librarian.yaml during serialization.
| - [google-cloud-security-publicca==0.7.0](https://github.com/googleapis/google-cloud-python/tree/main/packages/google-cloud-security-publicca/CHANGELOG.md) | ||
| - [google-cloud-quotas==0.7.0](https://github.com/googleapis/google-cloud-python/tree/main/packages/google-cloud-quotas/CHANGELOG.md) |
There was a problem hiding this comment.
The list of changelogs is not correctly sorted alphabetically. For example, google-cloud-security-publicca (line 150) is misplaced relative to google-cloud-quotas (line 151). Additionally, entries with suffixes like google-cloud-alloydb-connectors (line 19) appear before their base package google-cloud-alloydb (line 20). This suggests a potential issue in the sorting logic of the librarian tool used to generate this file.
| - path: google/bigtable/admin/v2 | ||
| skip_generate: true | ||
| # TODO(b/501132869): Disabling automatic releases until resolved. | ||
| skip_release: true |
There was a problem hiding this comment.
The explanatory comment for skip_release: true was removed. Note that comments in librarian.yaml are not preserved during YAML serialization. Please document the explanation for this configuration (e.g., the reference to b/501132869) in config.yaml instead. If the underlying issue is resolved, consider removing the skip_release and skip_generate restrictions.
References
- Comments in
librarian.yamlare not preserved during YAML serialization. Explanations for configurations, such asskip_release, should be documented in other files likeconfig.yaml.
2 participants
wip