fix(bigtable): Fix mutate rows logic to handle errors#30766
Merged
aandreassa merged 2 commits intomainfrom Aug 11, 2025
Merged
Conversation
7b41161 to
33fc416
Compare
33fc416 to
1489a4c
Compare
dazuma
previously approved these changes
Aug 8, 2025
Contributor
Author
|
@dazuma I had to merge |
dazuma
approved these changes
Aug 11, 2025
Contributor
|
Make sure the conventional commit tag gets fixed. This should at least be a |
shubhangi-google
pushed a commit
to shubhangi-google/google-cloud-ruby
that referenced
this pull request
Aug 25, 2025
shubhangi-google
pushed a commit
to shubhangi-google/google-cloud-ruby
that referenced
this pull request
Sep 2, 2025
shubhangi-google
pushed a commit
to shubhangi-google/google-cloud-ruby
that referenced
this pull request
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR combines fixes for 3 conformance tests.
TestMutateRows_Retry_ExponentialBackoff,TestMutateRows_Retry_WithRoutingCookieandTestMutateRows_Retry_WithRetryInfo(b/405212985)mutate_rowsfails, we want to push down the error status into each mutations.RETRY_LIMITlogic seems to have an off-by-one error. When I run the tests as is, I get the error below:Tests are in googleapis/cloud-bigtable-clients-test.