Skip to content

chore: make sure memory service is setup in streaming_agent_run_with_response #6246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: make sure memory service is setup in streaming_agent_run_with_response #6246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions vertexai/agent_engines/templates/adk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1149,18 +1149,19 @@ async def streaming_agent_run_with_events(self, request_json: str):
from google.genai.errors import ClientError

request = _StreamRunRequest(**json.loads(request_json))
if not self._tmpl_attrs.get("in_memory_runner"):
self.set_up()
if not self._tmpl_attrs.get("runner"):
self.set_up()
# Prepare the in-memory session.
if not self._tmpl_attrs.get("in_memory_artifact_service"):
self.set_up()
if not self._tmpl_attrs.get("artifact_service"):
self.set_up()
if not self._tmpl_attrs.get("in_memory_session_service"):
self.set_up()
if not self._tmpl_attrs.get("session_service"):
if not any(
self._tmpl_attrs.get(service)
for service in (
"in_memory_runner",
"runner",
"in_memory_artifact_service",
"artifact_service",
"in_memory_session_service",
"session_service",
"in_memory_memory_service",
"memory_service",
)
):
self.set_up()
app = self._tmpl_attrs.get("app")

Expand Down
26 changes: 13 additions & 13 deletions vertexai/preview/reasoning_engines/templates/adk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -989,20 +989,20 @@ def streaming_agent_run_with_events(self, request_json: str):

async def _invoke_agent_async():
request = _StreamRunRequest(**json.loads(request_json))
if not self._tmpl_attrs.get("in_memory_runner"):
self.set_up()
if not self._tmpl_attrs.get("runner"):
self.set_up()
# Prepare the in-memory session.
if not self._tmpl_attrs.get("in_memory_artifact_service"):
self.set_up()
if not self._tmpl_attrs.get("artifact_service"):
self.set_up()
if not self._tmpl_attrs.get("in_memory_session_service"):
self.set_up()
if not self._tmpl_attrs.get("session_service"):
if not any(
self._tmpl_attrs.get(service)
for service in (
"in_memory_runner",
"runner",
"in_memory_artifact_service",
"artifact_service",
"in_memory_session_service",
"session_service",
"in_memory_memory_service",
"memory_service",
)
):
self.set_up()

# Try to get the session, if it doesn't exist, create a new one.
if request.session_id:
session_service = self._tmpl_attrs.get("session_service")
Expand Down
Loading