refactor: Decorator to take docs rather than inheritance#2467
Merged
TrevorBergeron merged 6 commits intomainfrom Feb 19, 2026
Merged
refactor: Decorator to take docs rather than inheritance#2467TrevorBergeron merged 6 commits intomainfrom
TrevorBergeron merged 6 commits intomainfrom
Conversation
product-auto-label
bot
added
size: l
sycai
reviewed
Feb 19, 2026
Comment on lines
+23
to
+35
| if not target_class.__doc__ and source_class.__doc__: | ||
| target_class.__doc__ = source_class.__doc__ | ||
|
|
||
| for name, source_item in vars(source_class).items(): | ||
| if name in vars(target_class): | ||
| target_item = getattr(target_class, name) | ||
|
|
||
| if hasattr(target_item, "__doc__") and not target_item.__doc__: | ||
| if hasattr(source_item, "__doc__") and source_item.__doc__: | ||
| try: | ||
| target_item.__doc__ = source_item.__doc__ | ||
| except AttributeError: | ||
| pass |
Contributor
There was a problem hiding this comment.
Do we want to raise an error if both the target and the source have docs, assuming that all the docs should be placed in that vendored directory?
tswast
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕