Skip to content

fix!: change the fabric codegen defaults to match the native SDKs #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
illuminati1911 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix!: change the fabric codegen defaults to match the native SDKs #596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ios/react-native-navigation-sdk/NavView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,13 @@

using namespace facebook::react;

static const std::shared_ptr<const NavViewProps> kDefaultNavViewProps =
std::make_shared<const NavViewProps>();
static const std::shared_ptr<const NavViewProps> kDefaultNavViewProps = [] {
auto props = std::make_shared<NavViewProps>();
// On iOS, Google Maps Navigation SDK has the compass disabled by default.
// The Fabric default is overridden here so initial props match the native SDK behavior.
props->compassEnabled = false;
return std::static_pointer_cast<const NavViewProps>(props);
}();

@interface NavView () <RCTNavViewViewProtocol>

Expand Down
2 changes: 1 addition & 1 deletion src/native/NativeNavViewComponent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export interface NativeNavViewProps extends ViewProps {
headerEnabled?: WithDefault<boolean, true>;
footerEnabled?: WithDefault<boolean, true>;
speedometerEnabled?: WithDefault<boolean, true>;
speedLimitIconEnabled?: WithDefault<boolean, true>;
speedLimitIconEnabled?: WithDefault<boolean, false>;
recenterButtonEnabled?: WithDefault<boolean, true>;
reportIncidentButtonEnabled?: WithDefault<boolean, true>;
navigationViewStylingOptions?: UnsafeMixed;
Expand Down
Loading