Skip to content

fix(gmail): improve attachment data handling#816

Open
Lubrsy706 wants to merge 1 commit into
googleworkspace:mainfrom
Lubrsy706:rescue/gmail-attachment-handling
Open

fix(gmail): improve attachment data handling#816
Lubrsy706 wants to merge 1 commit into
googleworkspace:mainfrom
Lubrsy706:rescue/gmail-attachment-handling

Conversation

@Lubrsy706
Copy link
Copy Markdown

@Lubrsy706 Lubrsy706 commented May 19, 2026

Summary

  • pad Gmail attachment data responses from users.messages.attachments.get so standard base64url decoders can consume them directly
  • keep the normalization scoped to the Gmail attachment get method
  • update the save-email-attachments recipe to decode attachment bytes before upload and use the current gws drive +upload file argument form
  • add a patch changeset

This combines and refreshes the attachment-related fixes from #795 and #797 after those PRs were closed by the stale bot.

Testing

  • cargo test -p google-workspace-cli test_pad_gmail_attachment_data
  • git diff origin/main..HEAD --check

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 19, 2026

🦋 Changeset detected

Latest commit: 761a113

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@googleworkspace/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses issues with Gmail attachment data handling by introducing automatic padding for base64url encoded responses. By normalizing these responses at the point of retrieval, the CLI ensures that downstream tools can consume the data without manual intervention. Additionally, the documentation and recipes have been updated to reflect the recommended workflow for downloading and decoding these attachments.

Highlights

  • Gmail Attachment Padding: Implemented automatic base64url padding for Gmail attachment responses to ensure compatibility with standard decoders.
  • Recipe Update: Updated the 'save-email-attachments' recipe to include a robust decode-and-upload flow using base64 decoding.
  • Testing: Added comprehensive unit tests to verify the padding logic and ensure it remains scoped only to the relevant Gmail API method.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Generative AI Prohibited Use Policy, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves Gmail attachment handling by ensuring base64-encoded attachment data is correctly padded in JSON responses. It introduces a normalize_json_response function in the executor to handle specific method requirements, specifically adding '=' padding for the gmail.users.messages.attachments.get endpoint. The documentation and recipes were also updated to include a decode-and-upload flow using jq and python3 for base64url decoding, and unit tests were added to verify the padding logic. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants