Skip to content

fix(auth): expose Gmail settings scope#817

Open
Lubrsy706 wants to merge 1 commit into
googleworkspace:mainfrom
Lubrsy706:rescue/gmail-settings-scope
Open

fix(auth): expose Gmail settings scope#817
Lubrsy706 wants to merge 1 commit into
googleworkspace:mainfrom
Lubrsy706:rescue/gmail-settings-scope

Conversation

@Lubrsy706
Copy link
Copy Markdown

Summary

  • add https://www.googleapis.com/auth/gmail.settings.basic to the --full auth scope set
  • expose it in the manual scope picker as "Gmail Settings"
  • keep it out of default/minimal scopes so first-run login stays conservative
  • only filter it as redundant when https://mail.google.com/ is also present; gmail.modify is intentionally not treated as a broader substitute
  • add a patch changeset and regression coverage

This refreshes #794 with the conservative scope design kept explicit. Gmail settings endpoints such as filters.list require gmail.settings.basic: https://developers.google.com/workspace/gmail/api/reference/rest/v1/users.settings.filters/list

Testing

  • cargo test -p google-workspace-cli settings_basic
  • cargo test -p google-workspace-cli resolve_scopes
  • git diff --cached --check

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 19, 2026

🦋 Changeset detected

Latest commit: 3ea3270

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@googleworkspace/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Google Workspace CLI by exposing the 'gmail.settings.basic' scope, which is required for accessing specific Gmail settings endpoints like filters. The changes ensure this scope is available for advanced users while maintaining a conservative default for first-time logins. The implementation includes updated scope resolution logic and regression tests to ensure correct behavior during authentication flows.

Highlights

  • Scope Expansion: Added the 'gmail.settings.basic' scope to the full authentication set and exposed it in the manual scope picker as 'Gmail Settings'.
  • Redundancy Logic: Updated the scope filtering logic to treat 'gmail.settings.basic' as redundant only when the broader 'mail.google.com' scope is present.
  • Regression Testing: Added comprehensive unit tests to verify scope resolution, default exclusion, and redundancy filtering behavior.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Generative AI Prohibited Use Policy, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the https://www.googleapis.com/auth/gmail.settings.basic scope to the Google Workspace CLI. The changes include adding the scope to the full authentication flow, defining it as redundant when the broader https://mail.google.com/ scope is present, and providing a corresponding label for the UI. Additionally, unit tests were added to ensure the scope is correctly handled during scope resolution and filtering. I have no feedback to provide as there were no review comments to evaluate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants