Refactor immediate operation test to drop dependency on StorageBuffer…#4619
Merged
shaoboyan091 merged 1 commit intogpuweb:mainfrom Mar 31, 2026
Merged
Refactor immediate operation test to drop dependency on StorageBuffer…#4619shaoboyan091 merged 1 commit intogpuweb:mainfrom
shaoboyan091 merged 1 commit intogpuweb:mainfrom
Conversation
…sInFragmentStage greggman@ pointed out that the previous immediates operation tests relies on StorageBuffersInFragmentStage, which will reduce the cover rate of the devices. (gpuweb#4558 (comment)) Remove usage of StorageBuffersInFragmentStage and directly rendering result out to do operation test
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the immediate-data operation tests to avoid relying on maxStorageBuffersInFragmentStage (especially in compatibility mode) by switching render-path verification from fragment-stage storage buffer writes to reading back an rgba32uint render target.
Changes:
- Removed the compatibility-mode skip logic tied to
StorageBuffersInFragmentStage. - Split pipeline creation into compute (storage-buffer output) vs render (fragment
vec4ucolor output torgba32uint) paths. - Added a unified
runAndCheckhelper that validates results via buffer readback (compute) or texture readback (render).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
greggman
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…sInFragmentStage
greggman@ pointed out that the previous immediates operation tests relies on StorageBuffersInFragmentStage, which will reduce the cover rate of the devices. (#4558 (comment))
Remove usage of StorageBuffersInFragmentStage and directly rendering result out to do operation test
Issue: #
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.