Skip to content

Add API validation tests on the extension subgroup-size-control#4642

Open
Jiawei-Shao wants to merge 1 commit into
gpuweb:mainfrom
Jiawei-Shao:test-subgroup-size-control-operation-test
Open

Add API validation tests on the extension subgroup-size-control#4642
Jiawei-Shao wants to merge 1 commit into
gpuweb:mainfrom
Jiawei-Shao:test-subgroup-size-control-operation-test

Conversation

@Jiawei-Shao
Copy link
Copy Markdown
Collaborator

This patch adds the API validation tests on the extension subgroup-size-control:

  • Enabling subgroup-size-control on the creation of device should also enable subgroups.

Issue: #4640


Requirements for PR author:

  • [*] All missing test coverage is tracked with "TODO" or .unimplemented().
  • [*] New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • [*] Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • [*] Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

This patch adds the API validation tests on the extension
`subgroup-size-control`:
- Enabling subgroup-size-control on the creation of device should
  also enable subgroups.
@github-actions
Copy link
Copy Markdown

Results for build job (at 6c5381b):

+webgpu:api,validation,capability_checks,features,subgroup_size_control:enables_subgroups:* - 1 cases, 1 subcases (~1/case)
-TOTAL: 281247 cases, 2322858 subcases
+TOTAL: 281248 cases, 2322859 subcases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant