Skip to content

Add shader execution tests on the feature subgroup-size-control#4643

Open
Jiawei-Shao wants to merge 1 commit into
gpuweb:mainfrom
Jiawei-Shao:test-subgroup-size-control-execution-test
Open

Add shader execution tests on the feature subgroup-size-control#4643
Jiawei-Shao wants to merge 1 commit into
gpuweb:mainfrom
Jiawei-Shao:test-subgroup-size-control-execution-test

Conversation

@Jiawei-Shao
Copy link
Copy Markdown
Collaborator

This patch adds the shader execution tests on the feature subgroup-size-control:

  • The value of the built-in variable subgroup_size must equal the value of the @subgroup_size attribute.
  • At least one value in the range of [subgroupMinSize, subgroupMaxSize] can be used as @subgroup_size
    attribute in a simple compute pipeline.

Issue: #4640


Requirements for PR author:

  • [*] All missing test coverage is tracked with "TODO" or .unimplemented().
  • [*] New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • [*] Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • [*] Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

This patch adds the shader execution tests on the feature
`subgroup-size-control`:
- The value of the built-in variable `subgroup_size` must equal the
  value of the `@subgroup_size` attribute.
- At least one value in the range of [GPUAdapterInfo.subgroupMinSize,
  GPUAdapterInfo.subgroupMaxSize] can be used as `@subgroup_size`
  attribute in a simple compute pipeline.
@github-actions
Copy link
Copy Markdown

Results for build job (at 61ffb1c):

+webgpu:shader,execution,shader_io,compute_builtins:subgroup_size_attribute:* - 6 cases, 6 subcases (~1/case)
+webgpu:shader,execution,shader_io,compute_builtins:subgroup_size_attribute_valid_size_exists:* - 1 cases, 1 subcases (~1/case)
-TOTAL: 281247 cases, 2322858 subcases
+TOTAL: 281254 cases, 2322865 subcases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant