Skip to content

Bump version 2.3 → 2.4 with DB migration#666

Merged
KrzysztofPajak merged 2 commits intodevelopfrom
copilot/develop-version-2-4-migrations
Mar 29, 2026
Merged

Bump version 2.3 → 2.4 with DB migration#666
KrzysztofPajak merged 2 commits intodevelopfrom
copilot/develop-version-2-4-migrations

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 29, 2026

  • Update version from 2.3.0 to 2.4.0 in Grand.Common.props
  • Create Migrations/2.4/MigrationUpgradeDbVersion_24.cs migration
  • Fix MigrationManagerTests.GetCurrentMigrationsTest — update baseline DbVersion from (2,3) to (2,4) to match the new version

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Advances the codebase to version 2.4 by bumping the shared build version and adding the corresponding database migration that updates the stored GrandNodeVersion DB version values.

Changes:

  • Bump shared <Version> from 2.3.0 to 2.4.0 in build props.
  • Add migration MigrationUpgradeDbVersion_24 targeting DbVersion(2, 4) to persist the updated DB version in GrandNodeVersion.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Modules/Grand.Module.Migration/Migrations/2.4/MigrationUpgradeDbVersion_24.cs Adds the 2.4 DB version upgrade migration following the existing 2.3 pattern.
src/Build/Grand.Common.props Updates the shared build/version property to 2.4.0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@KrzysztofPajak
Copy link
Copy Markdown
Member

@copilot fix tests

Agent-Logs-Url: https://github.com/grandnode/grandnode2/sessions/33c01318-25b2-4ea5-b333-84eaafaafb42

Co-authored-by: KrzysztofPajak <16772986+KrzysztofPajak@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 29, 2026

@copilot fix tests

Fixed in cd7382b. MigrationManagerTests.GetCurrentMigrationsTest was using DbVersion(2, 3) as the baseline, which caused both MigrationTest1 (now 2.4) and MigrationTest2 (now 3.4) to satisfy > 2.3, returning 2 items instead of the expected 1. Updated the baseline to DbVersion(2, 4) so only MigrationTest2 (version 3.4) is returned. All 83 tests pass.

@sonarqubecloud
Copy link
Copy Markdown

@KrzysztofPajak KrzysztofPajak merged commit 3278184 into develop Mar 29, 2026
7 checks passed
@KrzysztofPajak KrzysztofPajak deleted the copilot/develop-version-2-4-migrations branch March 29, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants