graph: Re-enable postponed index creation in debug builds#6614
Open
incrypto32 wants to merge 1 commit into
Open
graph: Re-enable postponed index creation in debug builds#6614incrypto32 wants to merge 1 commit into
incrypto32 wants to merge 1 commit into
Conversation
The v0.44.0 disable patch hardcoded `postpone_attribute_index_creation` to `false`, which broke three `relational::ddl_tests` (`generate_ddl`, `generate_postponed_indexes`, `postponed_indexes_with_block_column`) that exercise the postponed-index DDL path and relied on the prior `cfg!(debug_assertions)` auto-on for that coverage. Switch the field to `cfg!(debug_assertions)` so: - Release builds (production): postponement stays off regardless of env var, matching the intent of the original disable. - Debug builds (CI + dev): postponement is on, so the existing tests exercise the code path and pass. The `GRAPH_POSTPONE_ATTRIBUTE_INDEX_CREATION` env var stays inert (parsed but unused, hence the existing `#[allow(unused)]`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to v0.44.0 (#6611): the disable patch hardcoded
postpone_attribute_index_creationtofalse, which broke CI inrelational::ddl_tests(generate_ddl,generate_postponed_indexes,postponed_indexes_with_block_column).Switching to
cfg!(debug_assertions)keeps the production behavior(release builds: postponement off, env var inert) and re-enables it
for debug builds so the tests pass.