feat(History): add lazy mode to load more chats#118
Merged
Conversation
ananas7
requested review from
Postamentovich,
mariamelior and
niktverd
as code owners
Contributor
|
🚀 Prerelease version published! Install this PR version: npm i --save-dev @gravity-ui/aikit@1.11.1-beta.1d2e5c8e60e456f30f447051a22c00c8fdebc84c.0 |
| } = props; | ||
| const [filteredItemCount, setFilteredItemCount] = useState<number | null>(null); | ||
| const [loadedChats, setLoadedChats] = useState<ChatType[]>([]); | ||
| const [lazyLoading, setLazyLoading] = useState(false); |
Contributor
There was a problem hiding this comment.
Why you have two state of loading? lazyLoading and isLoadingRef ?
Is it for optimization?
| }, [filterFunction]); | ||
|
|
||
| const handleLoadMoreClick = useCallback(() => { | ||
| (onLoadMore as () => void)?.(); |
Contributor
There was a problem hiding this comment.
I think you need to call handleLazyLoadMore here
ananas7
force-pushed
the
add-history-lazy-load
branch
from
b30c1e5 to
c5a7f01
Compare
|
Preview is ready. |
ananas7
force-pushed
the
add-history-lazy-load
branch
from
c5a7f01 to
dfbe2b2
Compare
ananas7
force-pushed
the
add-history-lazy-load
branch
from
dfbe2b2 to
1d2e5c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.