feat(design): add aria-controls support to DaffMenuComponent

[fiona-cai]

PR Checklist

• Commit message follows our contributing guidelines
• Tests added/updated (for bug fixes/features)
• Documentation added/updated (for bug fixes/features)

PR Type

• Bug fix
• Feature
• Style update
• Refactor
• Test
• Build
• CI
• Docs
• Performance
• Other (please describe)

Current behavior

Fixes: #4159

New behavior

• Menu activator reserves unique menu id on init, which it uses for its aria-controls
• When menu is opened, the menu activator passes the menu id to the menu component through injection
• Menu IDs are unique because all menu activators access the same instance of daffMenuUniqueId
• aria-controls of menu activator always matches id of menu component

Breaking change?

• Yes
• No

Additional context

[xelaint]

fix(design): resolve spec failures in textarea, tree, and progress-bar should be moved to a separate PR

[fiona-cai]

fix(design): resolve spec failures in textarea, tree, and progress-bar should be moved to a separate PR

is there a current issue open for it?

[xelaint]

fix(design): resolve spec failures in textarea, tree, and progress-bar should be moved to a separate PR

is there a current issue open for it?

#4317

I created the issue since the updates are valid, but these tests don't actually fail on my end since the tests itself don't rely on the missing imports. Are they actually causing a fail on your end?

[fiona-cai]

yeah, they do

[xelaint]

yeah, they do

okay that's interesting since the CI pipeline passes

fixed.

[damienwebdev]

lgtm

[damienwebdev]

Many thanks @fiona-cai -- apologies for the slow review on this! I'm temporally challenged these days.