You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Removed the old sortBump counter since the atomicAdd there was slowing the
kernel down a lot. Now the workgroup ID just comes from builtinsUniform.wgid.x,
so we don’t hit any global atomics. Also cleared the hist/passHist before each run.
This improves bandwidth graph.
Fix plot stroke=timing for proper GPU/CPU lines; expand input range + trials.
Consider the case that the hardware issued all the blocks with the largest wgid first and all the small wgids were not issued and were waiting on the larger wgids to finish. If we didn't have fallback in this code, it would lock up for sure (because the resident workgroups would be waiting for workgroup 0 to finish, but workgroup 0 would not have launched yet). This particular code will not lock up, because we do have fallback, but if we fallback, performance will be terrible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the old sortBump counter since the atomicAdd there was slowing the
kernel down a lot. Now the workgroup ID just comes from builtinsUniform.wgid.x,
so we don’t hit any global atomics. Also cleared the hist/passHist before each run.
This improves bandwidth graph.
Fix plot stroke=timing for proper GPU/CPU lines; expand input range + trials.