Allow unknown fields in Edge config models#418
Merged
timmarkhuff merged 5 commits intomainfrom Mar 20, 2026
Merged
Conversation
CoreyEWood
approved these changes
Mar 20, 2026
Contributor
CoreyEWood
left a comment
CoreyEWood
left a comment
There was a problem hiding this comment.
Looks good, just a small suggestion for the test.
test/unit/test_edge_config.py
Outdated
Comment on lines
+238
to
+241
| def test_edge_endpoint_config_ignores_extra_top_level_fields(): | ||
| """Unknown fields are silently ignored for forward compatibility (Postel's Law).""" | ||
| config = EdgeEndpointConfig.model_validate({"global_config": {}, "unknown_field": True}) | ||
| assert config.global_config == GlobalConfig() |
Contributor
There was a problem hiding this comment.
To make this even more thorough, this could verify that extra fields within nested objects (e.g., inside global_config) are also ignored.
Contributor
Author
There was a problem hiding this comment.
Good catch. I have extended the test to check nested objects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To minimize potential breaking changes when a client uses a different version of the edge config than the edge-endpoint, we should allow unknown fields.
This changes means that the edge-endpoint will accept any fields it doesn't know about without raising exceptions, and then just ignore them, which is likely the best way of handling a version mismatch.