feat: add Codecov integration for unit test coverage#543
Open
ptomanRH wants to merge 1 commit into
Open
Conversation
Reviewer's GuideAdds Codecov coverage reporting by generating lcov output from c8, uploading coverage from the Node 24 CI job via OIDC, and configuring Codecov project/patch statuses, flags, and ignore patterns. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider relying on Codecov’s default
slug(fromGITHUB_REPOSITORY) instead of hardcodingguacsec/trustify-da-javascript-clientin the upload step to avoid issues if the repository is renamed or the workflow is reused elsewhere.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider relying on Codecov’s default `slug` (from `GITHUB_REPOSITORY`) instead of hardcoding `guacsec/trustify-da-javascript-client` in the upload step to avoid issues if the repository is renamed or the workflow is reused elsewhere.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
ruromero
requested changes
Jun 2, 2026
| use_oidc: true | ||
| flags: unit-tests | ||
| files: ./coverage/lcov.info | ||
| slug: guacsec/trustify-da-javascript-client |
Collaborator
There was a problem hiding this comment.
Replace hardcoded slug with ${{ github.repository }}
- Add lcov reporter to c8 config for Codecov-compatible output - Add Codecov upload step to test workflow with OIDC auth - Add permissions: id-token: write for OIDC token - Add codecov.yml with informational status checks and unit-tests flag Ref: COVERPORT-254 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
70b822a to
291595e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lcovreporter to c8 config so Codecov can parse coverage outputMAIN_NODE_VER)codecov.ymlwith informational status checks,unit-testsflag with carryforwardChanges
package.jsonlcovto c8 reporter list.github/workflows/test.ymlpermissions: id-token: write+ Codecov upload stepcodecov.ymlManual follow-up
After merging:
Ref: COVERPORT-254
Summary by Sourcery
Integrate Codecov coverage reporting into the project’s CI test workflow and configuration.
New Features:
Enhancements:
CI: