Upgraded all the packages inside of Pipfile.lock to most recent versi…#55
Open
zachjesus wants to merge 7 commits into
Open
Upgraded all the packages inside of Pipfile.lock to most recent versi…#55zachjesus wants to merge 7 commits into
zachjesus wants to merge 7 commits into
Conversation
…ons. Fixed syntax issues in Models.py preventing sqlalchemy upgrade.
…sed imports and missing types. Fixed logging imports. Corrected types for sqlalchemy within Models.py.
Contributor
|
The code in Logging is how log entries for Ebookmaker and Ebookconverter are supposed to get the book number added - I've not fully understood how it did this and when it didn't. The changes you made here don't seem to change anything; in the other programs I've blindly used the Logging log methods assuming that things like ebook number and loglevel got propagating as expected. Maybe we want to review use of these methods and fix where nessesary. |
Contributor
|
I've used Typing hardly at all (The code I inherited was written before Typing) so maybe you can explain where it is needed, what it does in this code, and where else it would be helpful.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ons. Fixed syntax issues in Models.py preventing sqlalchemy upgrade.