feat: allow upload of prerecorded videos#136
Closed
eofreternal wants to merge 1 commit intohackclub:mainfrom
Closed
feat: allow upload of prerecorded videos#136eofreternal wants to merge 1 commit intohackclub:mainfrom
eofreternal wants to merge 1 commit intohackclub:mainfrom
Conversation
Contributor
Author
|
Because of the refactor, the entire codebase changed. I'll have to come back with a new commit |
Member
|
Thank you for still going at this! <3 I think that with V2 being out, you should be able to just call As for snapshots - I'm thinking of ditching them entirely, because right now we have two sources of truth for the time recorded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #72
People can upload MKVs and MP4s and whatnot and they'll be converted into a WebM before being uploaded to the server
One thing to note: it takes a while to convert an MP4 into a WebM (0.25x) even on hardware that is still usable (Intel core i5 8th gen)