Added default permissions for lint-scss.yml file#8677
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Local Workflow Testing Workflows/Events Tested Commands Used Results |
|
Review ETA: By Thurs 06/04 6PM |
castillios
left a comment
There was a problem hiding this comment.
Hi @sushma110396,
Excellent work! I tested your changes to lint-scss.yml locally on my own fork, and the test logs for the Lint SCSS workflow also returned successfully.
I tested this by checking out your branch into my fork and opening it as a PR there. This triggered the Lint SCSS workflow, thus utilizing your updated .yml file: Local Test Log
As for PR logistics everything looks good: branches are correctly set, issue is linked and assigned, CodeQL alerts and issue actions items have been checked off. Thank you for including detailed test logs as well as how to recreate them!
PR approved :)
Fixes #8583
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
No visual changes to the website. Please refer to the attached logs for reviewing the action output.
act-log.txt
act-pr-log.txt