removed slack-join-meeting-channel.svg#8693
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 06/05/2026 EOD |
|
Review ETA: Thurs 06/04 EOD |
There was a problem hiding this comment.
Hi @emoore36!
Everything looks good to me on this PR. The correct .svg file has been removed and each of the pages still maintain the Slack icon after the removal, as intended.
Thank you for including screenshots of all of the affected changes. I looked through each of the pages with your change locally, and my site matches your screenshots.
PR Logistics
- Issue is correctly linked and assigned
- Branches are correctly set
- CodeQL alerts and action items have been checked off
- Visual examples included
Thank you for work on this issue! PR approved :)
egcuriel
left a comment
There was a problem hiding this comment.
Hi @emoore36 !
I have reviewed this pull request and verified the following:
PR Verification:
✓ Pull Request uses the correct branch
✓ Original issue is linked
Technical Verification:
✓ Issue requirements are addressed correctly
✓ Changes are accurately represented locally across desktop and mobile viewports
✓ No new console errors or warnings present
Notes:
I appreciate you providing screenshots of the changes (there were a lot). I did find it difficult to see the changes due to the low contrast between the icons and the background, but I've verified the changes locally and they all of pages render successfuly after the deletion of the file.
Status: PR Approved!
Fixes #7857
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Getting Started
Getting started - 1
Getting started - 2
Footer (all pages)
Join Slack Channel
How to Set Reminders in Slack
Communities of Practice
Communities of Practice - 1
Communities of Practice - 2
Communities of Practice - 3
Communities of Practice - 4
Sample Project
Visuals after changes are applied
Getting Started
Getting started - 1
Getting started - 2
Footer (all pages)
Join Slack Channel
How to Set Reminders in Slack
Communities of Practice
Communities of Practice - 1
Communities of Practice - 2
Communities of Practice - 3
Communities of Practice - 4
Sample Project