Skip to content

HCK-9185: [MySQL] Invalid 'KEY' index type is available for select in PP #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VitaliiBedletskyi merged 2 commits into from
Jan 3, 2025
Merged

HCK-9185: [MySQL] Invalid 'KEY' index type is available for select in PP #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
307bc64
HCK-9185: [MySQL] Invalid 'KEY' index type is available for select in PP
Nightlngale Jan 2, 2025
d5a1e16
Merge branch 'develop' into HCK-9185
Nightlngale Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions forward_engineering/ddlProvider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,8 +432,7 @@ module.exports = (baseProvider, options, app) => {

const allDeactivated = checkAllKeysDeactivated(index.indxKey || []);
const wholeStatementCommented = index.isActivated === false || !isParentActivated || allDeactivated;
const indexType =
index.indexType && _.toUpper(index.indexType) !== 'KEY' ? `${_.toUpper(index.indexType)} ` : '';
const indexType = index.indexType ? `${_.toUpper(index.indexType)} ` : '';
const name = wrap(index.indxName || '', '`', '`');
const table = getTableName(tableName, dbData.databaseName);
const indexCategory = index.indexCategory ? ` USING ${index.indexCategory}` : '';
Expand Down
2 changes: 1 addition & 1 deletion properties_pane/entity_level/entityLevelConfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1727,7 +1727,7 @@ making sure that you maintain a proper JSON format.
"propertyTooltip": "",
"propertyType": "select",
"defaultValue": "",
"options": ["", "KEY", "UNIQUE", "FULLTEXT", "SPATIAL"]
"options": ["", "UNIQUE", "FULLTEXT", "SPATIAL"]
},
{
"propertyName": "Category",
Expand Down
6 changes: 2 additions & 4 deletions reverse_engineering/helpers/mysqlHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,11 +303,9 @@ const getIndexType = index => {
return 'SPATIAL';
} else if (Number(index['Non_unique']) === 0) {
return 'UNIQUE';
} else if (index['Index_type'] === 'KEY') {
return 'KEY';
} else {
return '';
}

return '';
};

const getIndexCategory = index => {
Expand Down