This repository was archived by the owner on Oct 13, 2025. It is now read-only.
New version of concurrent-ruby (1.2.0) broke the build#665
Closed
depfu[bot] wants to merge 1 commit intomainfrom
Closed
New version of concurrent-ruby (1.2.0) broke the build#665depfu[bot] wants to merge 1 commit intomainfrom
depfu[bot] wants to merge 1 commit intomainfrom
Conversation
Author
|
Closed in favor of #666. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've tested your project with an updated dependency and the build failed.
This version is either within the version range you specified or you haven't specified a version/range. To be able to test your project with the new version, we've taken the liberty of pinning the version for this branch and pull request.
Unfortunately, we encountered failing tests after pinning. This means that this new version is not compatible with your project and the test failure will potentially also happen on fresh installs.
If you have correctly specified a semantic versioning version range, you should probably also file an issue with the upstream project as they might have released an update that's breaking SemVer rules, which is not cool. (But then again, not all projects explicitly follow SemVer)
We've left the pull request open for you to investigate this issue. Please don't merge it as is, because, again, we've pinned the version of concurrent-ruby for this test run.
What changed?
✳️ concurrent-ruby (~> 1.0 → 1.2.0) · Repo · Changelog
Release Notes
1.2.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 63 commits:
Fix rake release:testAdapt RakeCompilerDock to work with podmanSeems plain `sh 'bundle package'` does not workRemove uptodate docs tasks1.2.0More docs fixesHide internal classes from public docsUpdate CHANGELOGVarious fixes for ThreadLocalVar and FiberLocalVarFix missing method `on_cruby?`.Add missing `require "concurrent/set.rb"`.Mark the `mutex_owned_per_thread?` method as private.Revert back to shared implementation of "locals" storage array.Introduce FiberLocalVar and LockLocalVar for alignment with `Mutex` scope.Don't compile the extension on non-CRuby, it's unusedReview usages of defined?Ensure each file can be required separatelyRun each spec file in a process to detect missing requiresFix cycle between configuration and loggingSome notes about setting up IntelliJUpdate the list of maintainersEnsure the java extension is always loaded before it's neededThe java extension is non-optionalSimplify dependencies in concurrent/synchronization/volatileRename to `@Lock` for consistency since it's a final ivarBe more explicit that it's only included onceExtract safe initialization and use it for MutexAtomic{Reference,Fixnum,Boolean}Do not depend on Synchronization::LockableObject for MutexAtomicBoolean and MutexAtomicFixnumFix circular dependency between AtomicReference and Synchronization::ObjectConcurrent.global_* should raise if there is an exception and not return nilSimplify Concurrent.monotonic_time to just use Process.clock_gettime(Process::CLOCK_MONOTONIC)MutexLockableObject/MonitorLockableObject never have any argumentsFix compiler warning (-Wold-style-definition)Cleanup old references to RbxAtomicReferencerake clean should remove lib/concurrent-ruby/concurrent/concurrent_ruby_ext.soSkip flaky specAdd Ruby 3.2 to the CI matrix. Also update checkout action versionLet `Promises.any_fulfilled_future` take an `Event`Update release docs instructionsdoc: typoResolvableEvent#resolve(true) should raise on reassignmentdoc: Return type of Promises.any_eventAdd release date of v1.1.10 to CHANGELOG.md (#968)Fix #monotonic_get_time documentation typoRequire Ruby 2.3+ and drop Ruby 2.2 supportUpdate docs for Concurrent.processor_countUse TruffleRuby release in main CIHide verbose and confusing "Pending: (Failures listed here ...)" section in RSpec outputFix warnings in extensionGuard spec which correctly fails on 3.1Avoid raise_error without exception classUse lambda literals in Concurrent::Map specRemove Rubinius-related codeRUBY_ENGINE is always definedFix documentation for Concurrent::Semaphoredocs: use bundler cacheNeeds BUNDLE_WITH documentationFix typoAutomatically generate docs for master and last releases using GitHub ActionsRemove docs from source repositoryFix docs: Concurrent::Map#fetch_or_store is not atomic_method_with_blockUpdate README.mdMerge pull request #942 from ruby-concurrency/prep-releaseDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands