fix: add Refs generic to PluginSpecificConfiguration interface#4551
Open
lgraziani2712 wants to merge 1 commit intohapijs:masterfrom
Open
fix: add Refs generic to PluginSpecificConfiguration interface#4551lgraziani2712 wants to merge 1 commit intohapijs:masterfrom
lgraziani2712 wants to merge 1 commit intohapijs:masterfrom
Conversation
…rface Add Refs generic to plugins key for CommonRouteProperties, extending the generic for logic inside plugins. This fixes situations where plugins API have lambdas where access the request object and requires to have the same Refs type from the route.
Contributor
|
@lgraziani2712 existing tests passed... But I still fear breaking people's builds.... What might happen is the inverse of this Can you add some typescript testing? In particular, spell out your use-case in tests (Happy path).
In fact, if you can pnpm link to your local build against those packages and see if it breaks their typings, that could be an issue. If there are no issues, screenshot and post here for us to see and further discuss! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Refs generic to plugins key for CommonRouteProperties, extending the generic for logic inside plugins.
This fixes situations where plugins API have lambdas where access the request object and requires to have the same Refs type from the route.
Fix #4526