feat: Add tsdown build setup with TypeScript support#165
Draft
akash-joshi wants to merge 3 commits intoharfbuzz:mainfrom
Draft
feat: Add tsdown build setup with TypeScript support#165akash-joshi wants to merge 3 commits intoharfbuzz:mainfrom
akash-joshi wants to merge 3 commits intoharfbuzz:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi folks, this PR adds tsdown build tooling with WebAssembly support, enabling TypeScript development for harfbuzzjs. This addresses the discussion in #99 about modernising the TypeScript setup.
This was based on @lianghai 's comment on the Svelte London chat. I wanted to create a rough draft of what a tsdown-based setup could look like.
AI Generated Summary Below
rolldown-plugin-wasmfor WASM supporthbjs.jsandhb.jssrc/index.ts) that re-exports typespackage.jsonwith dual ESM/CJS exports and build scriptsdist/with generated.d.tsdeclaration filesChanges
New files
tsdown.config.ts- Build config with WASM plugintsconfig.json- TypeScript compiler configurationsrc/index.ts- TypeScript entry pointsrc/types.d.ts- Type definitions (HBHandle, HBFont, HBBuffer, etc.)hbjs.d.ts- Sidecar type declarations for hbjs.jshb.d.ts- Sidecar type declarations for hb.jsModified files
package.json- Added build scripts, exports field, and dev dependencies.gitignore- Addeddist/Build output
Test plan
npx tsc --noEmit)npm run build:ts)npx mocha test/index.js)