Add codepoints_iter() methods for cmap Subtable4/Subtable12#174
Open
MoSal wants to merge 2 commits intoharfbuzz:mainfrom
Open
Add codepoints_iter() methods for cmap Subtable4/Subtable12#174MoSal wants to merge 2 commits intoharfbuzz:mainfrom
MoSal wants to merge 2 commits intoharfbuzz:mainfrom
Conversation
This allows early exit unlike `codepoints()`. Signed-off-by: Mohammad AlSaleh <CE.Mohammad.AlSaleh@gmail.com>
Author
|
Not really a draft. But only needed if a change in another crate (PR incoming) is accepted. |
Signed-off-by: Mohammad AlSaleh <CE.Mohammad.AlSaleh@gmail.com>
alerque
requested changes
Nov 29, 2024
| [package] | ||
| name = "ttf-parser" | ||
| version = "0.24.1" | ||
| version = "0.25.0" |
Member
There was a problem hiding this comment.
Please don't change the version number in PRs. Just the other changes will do and we can set the version as appropriate during the release process.
Member
There was a problem hiding this comment.
This still needs addressing to make this PR mergable. Would you rather I took care of it directly?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows early exit unlike
codepoints().