bugfix: change LazyOffsetArrayIter16 to ignore null offsets#212
Open
asibahi wants to merge 1 commit intoharfbuzz:mainfrom
Open
bugfix: change LazyOffsetArrayIter16 to ignore null offsets#212asibahi wants to merge 1 commit intoharfbuzz:mainfrom
asibahi wants to merge 1 commit intoharfbuzz:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this changes the
nextfunction inLazyOffsetArrayIter16to ignoreNonevalues in the array. All tests pass in tif-parser and rustybuzz. no code changes required in rustybuzz.closes #211 , as I noticed none of call sites in rustybuzz expect a non-fused iterator. (they're mostly
collectandanycalls).Edit:
Looking at the implementation of the corresponding data structure in read-fonts, it does not skip over the null offsets. However, all usage I could find
maporfilter_mapexcept in a test).