fix(hm): unbreak main — NonZeroU64 capacity in cache clean#137
Merged
Conversation
main was broken: #117 changed ImageRegistry::open to take NonZeroU64, but the cache-clean caller still passed u64::MAX (E0308). It slipped in as a semantic merge (no textual conflict), so main's hm binary stopped compiling on stable. This unbreaks main; every open PR is red only because GitHub builds them merged with this broken main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
maindoes not compile on stable (its ownCI/build-hm/exampleschecks are red, and every open PR is red because GitHub builds PRs merged with main).#117 changed
ImageRegistry::opento takeNonZeroU64, but thecache cleancaller still passedu64::MAX. No textual conflict, so it merged silently and brokemain.Fix
u64::MAX→std::num::NonZeroU64::MAX(const; noexpect, satisfies the crate'sexpect_usedlint).Verified (stable toolchain, fresh target)
cargo build -p harmont-cli✅cargo fmt --all --check✅cargo clippy --workspace --all-targets --locked -D warnings✅Merging this unblocks #126, #128, #133, #50, #87, #127.