fix: add missing security module declarations and cargo check to CI#25
Closed
fix: add missing security module declarations and cargo check to CI#25
Conversation
The security feature merge (#23) lost the mod.rs declarations for security and security_db during conflict resolution — files existed but weren't wired up, breaking desktop compilation. Adds cargo check to the desktop-build-test CI job so Rust compilation errors are caught before merge. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Closing — the fix is already on main (commit 3485d0b). The cherry-picked branch has zero diff against base. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pub mod securityandpub mod security_dbdeclarations tocommands/mod.rs— the files were merged in feat: Security page — permissions, secrets vault, audit log #23 but the module wiring was lost during conflict resolution, breaking desktop compilationcargo checkto thedesktop-build-testCI job so Rust compilation errors are caught before merge (previously only TypeScript/frontend was validated).devlaunch.ymlto.gitignoreTest plan
cargo checkpasses locallydesktop-build-testjob passes with the new Rust check steptauri devlaunches without compilation errors🤖 Generated with Claude Code