fix(Cabal): fix abi tag in case ghc's unit-id is the same as the compiler id#11652
Open
andreabedini wants to merge 1 commit intohaskell:masterfrom
Open
fix(Cabal): fix abi tag in case ghc's unit-id is the same as the compiler id#11652andreabedini wants to merge 1 commit intohaskell:masterfrom
andreabedini wants to merge 1 commit intohaskell:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When computing the ABI tag,
compilerIdis stripped as a common prefix fromGHC's "Project Unit Id" info entry via
stripCommonPrefix. When the projectunit-id exactly matches the compiler id,
stripCommonPrefixreturns"", andthe old code produced
AbiTag ""instead ofNoAbiTag.Rewrite
compilerAbiTagwith explicit case analysis so that a missing, empty,or fully-stripped "Project Unit Id" value correctly yields
NoAbiTag.