Hlint suggestion: avoid lambda using infix#11676
Merged
mergify[bot] merged 1 commit intohaskell:masterfrom Apr 11, 2026
Merged
Conversation
geekosaur
reviewed
Mar 29, 2026
geekosaur
reviewed
Mar 29, 2026
ffaf1
reviewed
Mar 29, 2026
Bodigrim
approved these changes
Mar 29, 2026
Collaborator
Bodigrim
left a comment
There was a problem hiding this comment.
I use this pattern extensively myself, so I'm supportive.
ulysses4ever
approved these changes
Mar 29, 2026
Collaborator
ulysses4ever
left a comment
There was a problem hiding this comment.
I don't have a preference either way, so I lean on the side of the volunteer. If someone feels strong, they should probably block.
93e82eb to
c19c52c
Compare
c19c52c to
e02a980
Compare
- Use `optional` in default and conversion branches - Use `infix` PerCompilerFlavor both ways
e02a980 to
e6c58c0
Compare
Contributor
Merge Queue Status
This pull request spent 1 hour 56 minutes 5 seconds in the queue, including 1 hour 45 minutes 21 seconds running CI. Required conditions to merge
|
86 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #9110. Discharges and no longer ignores HLint's "avoid lambda using `infix`" suggestion so that this will be suggested by our CI linting.
I find the suggested code is generally easy to read, such as
satisfy (`elem` xs). It avoids the need for primed or other temporary names, such asui'in: