Merged
Conversation
This has been requested, motivated by ergonomics (Seq.toList vs another import), type inference, consistency with other module APIs. A small downside is that it introduces an unnecessary choice for a user.
treeowl
approved these changes
Mar 29, 2026
Contributor
treeowl
left a comment
treeowl
left a comment
There was a problem hiding this comment.
I'm generally in favor. We've documented for ages that the modules in this package should be imported qualified or restricted, and it's idiomatic across modern packages to request specialized methods by using functions qualified by module.
| let n_pr = Prelude.length (toList pr) | ||
| let n_sf = Prelude.length (toList sf) | ||
| let n_pr = Prelude.length pr | ||
| n_sf = Prelude.length sf |
Contributor
There was a problem hiding this comment.
Whoa... Any idea why we had such a uselessly inefficient length calculation here before?
Contributor
Author
There was a problem hiding this comment.
These are Digits so it's up to 4 elements and I don't think it is noticeable. It might even end up the same after inlining and optimizations.
Contributor
There was a problem hiding this comment.
Oh yeah, I got mixed up. Still better to get it right.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been requested, motivated by ergonomics (Seq.toList vs another import), type inference, consistency with other module APIs. A small downside is that it introduces an unnecessary choice for a user.
Closes #1184