Open
Conversation
Contributor
Author
|
One more thing that we probably could try is... |
a0fb3e7 to
3c0cd0d
Compare
3c0cd0d to
4ab9e58
Compare
Contributor
Author
|
This is it Added an ability to access the operation name via static variable smth like |
Contributor
Author
|
If this approach makes sense for you I will finish the tests |
Contributor
|
Thanks for suggesting this @vasilich6107! Some minor suggestions: I think it would make sense to store the operation name next to the document node, e.g. const documentNodeMutationX = ...
const operantionNameMutationX = ...That way you will always generate the operation name regardless of the client being present. You can still expose it as you suggest on the options. I would be nice if we are consistent on exposing it across the options, also the watch-options. A protip for getting the tests updated would be to
|
Contributor
Author
|
Hi @budde377 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @budde377
this PR adds printing of an independent operation name for the cases when we do not use
graphqlandgraphql_flutterclients.For example when we use https://github.com/artflutter/graphql_flutter_bloc and want to pass
operationNametoWatchQueryOptionshttps://github.com/artflutter/graphql_flutter_bloc/blob/master/test/query_bloc_test.dart#L26
I see that there is a class
WatchOptions$Querybut it is being generated only in case if we add client generation.