Add ability to pass extra arguments to kustomize build command#147
Merged
Conversation
Copilot
AI
changed the title
[WIP] Ability to pass extra arguments to kustomize build.
Add ability to pass extra arguments to kustomize build command
Sep 9, 2025
Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com>
Adds support for passing extra arguments (e.g. --enable-exec for ksops) to the kustomize build command, exposed via ChartifyOpts.KustomizeBuildArgs and the CLI flag --kustomize-build-arg (repeatable). The args are threaded through both KustomizeBuild and Patch, appended before the positional build target. - Add KustomizeBuildArgs to ChartifyOpts, ExtraArgs to KustomizeBuildOpts and PatchOpts, and wire them through Chartify() - Add --kustomize-build-arg CLI flag - Rebase onto master: merge with SortOptions field and the kubectl-kustomize (bin/usingKubectl) plumbing - Remove accidentally committed 15MB chartify binary from the repo - Add spy-based tests verifying ExtraArgs reach the kustomize build command (replacing struct-literal-only assertions) - Update GenerateID hash expectations in tempdir_test.go (the new struct field changes the FNV hash over ChartifyOpts) Fixes #113. Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com> Signed-off-by: yxxhero <aiopsclub@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for passing extra arguments to the
kustomize buildcommand, which is needed for kustomize plugins like ksops that require additional flags such as--enable-exec.Changes Made
Core Implementation
ExtraArgs []stringfield toKustomizeBuildOptsstruct - allows passing extra arguments to kustomize build operationsKustomizeBuildArgs []stringfield toChartifyOptsstruct - exposes the functionality at the main API levelExtraArgs []stringfield toPatchOptsstruct - ensures consistent support across all kustomize operationsCLI Support
--kustomize-build-argflag - can be specified multiple times to pass extra argumentsTesting
Usage Examples
Single extra argument
chartify --kustomize-build-arg="--enable-exec" release-name /path/to/kustomizationMultiple extra arguments
Programmatic usage
Implementation Details
The extra arguments are appended to the kustomize build command after all standard flags:
This approach ensures compatibility with existing functionality while providing the flexibility needed for kustomize plugins.
Fixes #113.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.