Conversation
RobertLRead
approved these changes
Jan 15, 2026
Collaborator
RobertLRead
left a comment
RobertLRead
left a comment
There was a problem hiding this comment.
Dear @NimeshaKahingala and @JamesPagetButler,
I'm approving this request, but there are some things I don't understand about it. It appears to hard-code the cookie recipe, in a way that doesn't seem right. I'm sure it is an improvement---you can merge it you want---but I would like to understand this. Possibly it is reasonable to do, but if it is really hard-wiring a value like that, we need to document and understand. You can answer in Discord, if I have misunderstood, because I might have.
Collaborator
|
And, actually, you appear to be changing the port number, and I need to understand that--why is the port number changing? |
Collaborator
|
@NimeshaKahingala have you done an update since our last conversation? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.