chore: stop tracking lefthook-local.yml#1454
Merged
jrusso1020 merged 1 commit intoJun 15, 2026
Merged
Conversation
lefthook-local.yml is Lefthook's per-developer override file and is meant to stay local (the shared hooks live in lefthook.yml). It is currently committed, so it applies to everyone who clones the repo: a commit-msg hook in it appends a personal Co-authored-by trailer to every contributor's commit. Remove it from version control and add it to .gitignore so local overrides stay local. lefthook.yml (the shared config) is unchanged.
jrusso1020
approved these changes
Jun 15, 2026
jrusso1020
left a comment
jrusso1020
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed end-to-end — small, correct chore PR.
CI is green: every skipping job is gated behind the Detect changes path filter, and the checks that actually ran (CodeQL, Analyze, Format, File size check, regression, Semantic PR title) all passed. The BLOCKED state is just the review-required gate, not a failing required check.
Strengths
- Correctly diagnoses the root issue:
lefthook-local.ymlwas committed, so itscommit-msghook appendedCo-authored-by: Miguel Ángel <…>to every contributor's commits (lefthook-local.yml:6).*-local.ymlis Lefthook's per-developer override by design — committing it was the actual bug, andgit rm+.gitignoreis the right fix.
Verified
- Shared
lefthook.ymlis untouched; itscommit-msg: commitlintand allpre-commithooks (lint/format/typecheck/fallow/largefiles/filesize) are independent of the deleted file, so no shared hook regresses. - No code, script, doc, or CI references
lefthook-local.ymlanywhere — removal breaks nothing. - The Miguel co-author trailer appears only in this file (other "Miguel" matches are unrelated test comments/fixtures).
.gitignorehad no prior lefthook entry; the new ignore block is correct and well-commented.
No blockers, no nits.
Verdict: APPROVE
Reasoning: Clean cleanup that fixes a real (if minor) problem — an accidentally-tracked personal git hook polluting everyone's commit trailers. Shared config untouched, nothing references the removed file, CI green.
— pr-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove
lefthook-local.ymlfrom version control and add it to.gitignore.Why
lefthook-local.ymlis Lefthook's per-developer override file. By design it stays local and uncommitted; the shared hooks live inlefthook.yml. (Lefthook docs: local config)It is currently committed, so it applies to everyone who clones the repo. The file defines a
commit-msghook that appends a personalCo-authored-bytrailer to every contributor's commits, which isn't intended for shared use.Change
git rm lefthook-local.ymllefthook-local.ymlto.gitignoreso local overrides stay locallefthook.yml(the shared hook config) is untouched, so no shared hooks change. Anyone who wants a personal override can still create their ownlefthook-local.ymland it will now be ignored.