D11 General Applications Base PR#4927
Draft
adamg-hmcts wants to merge 13 commits into
Draft
Conversation
* NFDIV-5132 - Draft changes * NFDIV-5132 - Checkstyle corrections * NFDIV-5132 - reuse fields rather than create new * NFDIV-5132 - rename class to GeneralApplicationD11JourneyOptions * NFDIV-5132 - rename enum value * NFDIV-5132 - Reset any D11 gen app docs uploaded already and interim app type is changed * [NFDIV-5178] D11 general application payment journey/submission logic (#4906) * Payment journey and submission logic updates * Simplify submission service * Remove changes to service app logic * Correct state logic * Address unresolved merge conflict * Fix document collect code * [NFDIV-5179] D11 general application docmosis content (#4908) * Initial commit * Update general application submission service * Refactor template content * Checkstyle correction * Refactor class names for consistency with journey options * Tweak log messages * Remove extra bracket * Tweak label to match content document * Add new gen app awaiting docs state request by service team * [NFDIV-5390] General application D11 notifications (#4911) * Add notification generator and tests * Add template IDs * Correct variable name * Correct response date variable for hwf * [NFDIV-5134] Respondent D11 general application (#4921) * Add notification generator and tests * Add template IDs * Correct variable name * Correct response date variable for hwf * Update submission logic to work for both parties on the case * Make general application payment event available to respondents * Remove changes to set service type --------- Co-authored-by: adamg-hmcts <159780146+adamg-hmcts@users.noreply.github.com>
Contributor
Plan Result (aat) |
Contributor
Plan Result (prod) |
CCD diff report |
* Simplify save/sign out notifications * Give applicant delete access to interim apps docs * Rename interim application save and sign out email template * Checkstyle correction * More checkstyle corrections * Allow applicant 2 to update the case in more states
* NFDIV-5047 - Allow citizen to withdraw D11 * NFDIV-5047 - reset interimApplicationType on withdrawal. * NFDIV-5182 - Do not reset gen app type field (#4936) * NFDIV-5047 Use OptionalInt
* Set up state transitions for search government records * Refactor to improve clarity
* NFDIV-5387 - Caseworker general application payment event * NFDIV-5387 - Incorporate review feedback.
* Add awaiting pronouncement content to notification * Update tests to assert the previous state is set
* Add new general application party label * Refactor and add tests * Refactor enum check
CCD diff report |
CCD diff report |
CCD diff report |
CCD diff report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
Enter a description.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/NFDIV-5191
Pull request checklist
Before raising
Before merging
Note: Bug fixes, dependency updates and technical tasks do not directly impact the user experience and can be merged without QA and PO review.