Skip to content

API-8737 - Migrate to OQE #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AndySpaven wants to merge 3 commits into
base: main
Choose a base branch
from
Open

API-8737 - Migrate to OQE #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f1a9368
API-8737 - Migrate to OQE
AndySpaven Nov 5, 2025
e02141a
API-8737 - PR Bot comments
AndySpaven Nov 5, 2025
44364de
API-8737 - PR Bot comments
AndySpaven Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/uk/gov/hmrc/pushpullnotificationsapi/connectors/ThirdPartyApplicationConnector.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,6 @@ import uk.gov.hmrc.pushpullnotificationsapi.config.AppConfig
class ThirdPartyApplicationConnector @Inject() (http: HttpClientV2, appConfig: AppConfig)(implicit ec: ExecutionContext) {

def getApplicationDetails(clientId: ClientId)(implicit hc: HeaderCarrier): Future[ApplicationWithCollaborators] = {
http.get(url"${appConfig.thirdPartyApplicationUrl}/application?${Seq("clientId" -> clientId)}").execute[ApplicationWithCollaborators]
http.get(url"${appConfig.thirdPartyApplicationUrl}/query?clientId=$clientId").execute[ApplicationWithCollaborators]
}
}
2 changes: 1 addition & 1 deletion it/test/uk/gov/hmrc/pushpullnotificationsapi/support/ThirdPartyApplicationService.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import com.github.tomakehurst.wiremock.client.WireMock._
import uk.gov.hmrc.apiplatform.modules.common.domain.models.ClientId

trait ThirdPartyApplicationService {
val queryApplicationsUrl = "/application"
val queryApplicationsUrl = "/query"

def primeApplicationQueryEndpoint(status: Int, body: String, clientId: ClientId) = {
stubFor(get(urlPathEqualTo(queryApplicationsUrl))
Expand Down
8 changes: 4 additions & 4 deletions project/AppDependencies.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ import play.sbt.PlayImport._
object AppDependencies {
def apply(): Seq[ModuleID] = dependencies ++ testDependencies
val bootstrapVersion = "9.19.0"
val mongoVersion = "2.7.0"
val appEventVersion = "0.88.0"
val appDomainVersion = "0.87.0"
val mongoVersion = "2.10.0"
val appEventVersion = "0.90.0"
val appDomainVersion = "0.90.0"
val mockitoScalaVersion = "2.0.0"


Expand All @@ -23,7 +23,7 @@ object AppDependencies {
// "uk.gov.hmrc" %% "api-platform-application-domain" % appDomainVersion,
"com.github.blemale" %% "scaffeine" % "5.2.1",
"com.lihaoyi" %% "sourcecode" % "0.3.0",
"uk.gov.hmrc" %% "crypto-json-play-30" % "8.3.0",
"uk.gov.hmrc" %% "crypto-json-play-30" % "8.4.0",
"org.typelevel" %% "cats-core" % "2.10.0"
)

Expand Down
2 changes: 1 addition & 1 deletion project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ resolvers += Resolver.typesafeRepo("releases")

addSbtPlugin("uk.gov.hmrc" % "sbt-auto-build" % "3.24.0")
addSbtPlugin("uk.gov.hmrc" % "sbt-distributables" % "2.6.0")
addSbtPlugin("org.playframework" % "sbt-plugin" % "3.0.8")
addSbtPlugin("org.playframework" % "sbt-plugin" % "3.0.9")
addSbtPlugin("org.scoverage" % "sbt-scoverage" % "2.3.1")
addSbtPlugin("org.scalastyle" % "scalastyle-sbt-plugin" % "1.0.0")
addSbtPlugin("ch.epfl.scala" % "sbt-bloop" % "2.0.6")
Expand Down