Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly upgrades the glob dependency to version 13 to address security vulnerabilities and updates the Node.js engine requirement to 20 || >=22, dropping support for Node 18 as stated. The changes in package.json and package-lock.json are consistent and reflect these updates. I have one suggestion regarding dependency pinning to enhance the stability of the project.
Open
ec67f8d to
7439a74
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades the glob dependency from v9.0.0 to v13.0.6 to address deprecated status and published security vulnerabilities in glob v9.
Changes:
- Upgraded glob from ^9.0.0 to ^13.0.6 in package.json
- Updated package-lock.json with new dependency tree for glob v13 and its transitive dependencies
- Node engine requirement changed from ">=18" to "20 || >=22" in package-lock.json
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updated glob dependency version from ^9.0.0 to ^13.0.6 |
| package-lock.json | Updated lock file with glob v13 dependency tree, including updated versions of minimatch (v10.2.2), minipass (v7.1.3), path-scurry (v2.0.2), and their nested dependencies; removed @isaacs/balanced-match and @isaacs/brace-expansion dev dependencies; marked balanced-match and fs.realpath as dev dependencies; Node engine requirement changed to "20 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
glob@9 is deprecated with published security vulnerabilities. Upgrading to v13 (latest).