Skip to content

[Snyk] Security upgrade canvas from 2.10.2 to 3.0.0 #1183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Snyk] Security upgrade canvas from 2.10.2 to 3.0.0 #1183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/email-server/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"async": "^3.2.4",
"axios": "^0.27.2",
"bufferutil": "^4.0.7",
"canvas": "^2.10.2",
"canvas": "^3.0.0",
Copy link

@gemini-code-assist gemini-code-assist bot Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This upgrade to canvas is a major version bump (v2 to v3), which is flagged by Snyk as a breaking change. To ensure the stability and correctness of the application, it's crucial to perform the following actions:

  1. Update Lockfile: Run pnpm install to update the pnpm-lock.yaml file. The PR is incomplete without this change, and the new dependency version will not be used.
  2. Regression Testing: Thoroughly test all functionality that relies on canvas, such as email image generation, to verify that this major version upgrade has not introduced any breaking changes or visual regressions.

Merging without these steps could lead to broken functionality in production.

"cron": "^2.1.0",
"dotenv": "^16.0.3",
"encoding": "^0.1.13",
Expand Down
Loading