-
Notifications
You must be signed in to change notification settings - Fork 2
[Snyk] Fix for 4 vulnerabilities #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…lities The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-PYASN1-15032639 - https://snyk.io/vuln/SNYK-PYTHON-TORCH-10332644 - https://snyk.io/vuln/SNYK-PYTHON-TORCH-10332645 - https://snyk.io/vuln/SNYK-PYTHON-WHEEL-15053866
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, addresses four security vulnerabilities within the project's Python dependencies. It updates specific package versions in Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request from Snyk proposes upgrading pyasn1, torch, and wheel to address security vulnerabilities. While security is crucial, these changes, especially the major version upgrade of torch to 2.x, pose a critical risk of breaking the project. The PR description itself includes a long list of existing dependency conflicts, indicating a fragile environment. Merging this PR will likely exacerbate these issues and lead to a non-functional state. The upgrade of torch from 1.13.1 to >=2.10.0 is a major change that often includes breaking APIs, and it conflicts with the project's apparent strategy of avoiding major version bumps for key libraries like numpy and pydantic. Due to the high probability of introducing breaking changes and dependency conflicts, I recommend not merging this PR as is. A more robust approach is needed: first, address the existing dependency conflicts reported in the PR description; second, carefully evaluate the torch upgrade, addressing any necessary code changes; and third, consider using a dependency management tool like pip-tools to create a consistent, locked set of dependencies. This will ensure that security vulnerabilities are fixed without compromising the stability of the project.
| pyasn1>=0.6.2 # not directly required, pinned by Snyk to avoid a vulnerability | ||
| torch>=2.10.0 # not directly required, pinned by Snyk to avoid a vulnerability | ||
| wheel>=0.46.2 # not directly required, pinned by Snyk to avoid a vulnerability No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change introduces a major version upgrade for torch (from 1.x to >=2.10.0). This is a significant risk and is likely to introduce breaking API changes, which could break existing functionality that depends on torch (e.g., via torchmetrics). Other dependencies in this project, like pydantic and numpy, are carefully pinned to avoid major version upgrades, and the same caution should be applied here. Additionally, pinning transitive dependencies in this file can lead to a fragile dependency setup. The extensive list of warnings in the pull request description indicates that the dependency tree is already inconsistent. Merging these changes without resolving the underlying conflicts will likely break the environment. It is strongly recommended to reject this automated change and instead perform a comprehensive update of dependencies, resolving all conflicts, and thoroughly testing the application.
Snyk has created this PR to fix 4 vulnerabilities in the pip dependencies of this project.
Snyk changed the following file(s):
responsibleai_vision/requirements-automl.txtImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Allocation of Resources Without Limits or Throttling
🦉 Buffer Overflow
🦉 Directory Traversal