-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Fix for 2 vulnerabilities #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15032660 - https://snyk.io/vuln/SNYK-JS-LODASH-15053838
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically created by Snyk, addresses two security vulnerabilities by upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request from Snyk addresses two security vulnerabilities by updating canvas and lodash. However, the update for lodash to version 4.17.23 is highly suspicious, as this version is not an official release and may pose a security risk. This change should be rejected. The update for canvas is a major version bump to v3.0.0 to resolve a transitive vulnerability. This is a breaking change and requires thorough testing to ensure compatibility with your application, particularly with tools like jest-canvas-mock.
| "json5": "^2.1.0", | ||
| "localized-strings": "^0.2.4", | ||
| "lodash": "^4.17.11", | ||
| "lodash": "^4.17.23", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lodash package is being updated to version 4.17.23. This version is not an official release from the lodash maintainers and is not available on the public npm registry. The yarn.lock file points to a direct .tgz URL from registry.yarnpkg.com, which might be a cached version of a since-unpublished package. This is a significant security risk, as it could be a malicious package (e.g., dependency confusion). It is strongly recommended to reject this change and stick to the latest official version, 4.17.21, until an official patch for SNYK-JS-LODASH-15053838 is released by the lodash team.
| "lodash": "^4.17.23", | |
| "lodash": "^4.17.21", |
| "@fluentui/react": "8.58.0", | ||
| "@yarnpkg/parsers": "3.0.0-rc.48.1", | ||
| "canvas": "^2.11.2", | ||
| "canvas": "^3.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a major version upgrade for canvas (from v2 to v3), which introduces breaking changes as noted by Snyk. While this upgrade is necessary to fix the tar vulnerability (SNYK-JS-TAR-15032660), it requires thorough regression testing of all features that rely on canvas. The project's usage of jest-canvas-mock and other canvas-related tooling should be checked for compatibility with canvas v3.
Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
package.jsonyarn.lockNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15032660
SNYK-JS-LODASH-15053838
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Prototype Pollution
🦉 Directory Traversal