Skip to content

Conversation

@q1blue
Copy link

@q1blue q1blue commented Jan 28, 2026

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • code/frameworks/preact-webpack5/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Directory Traversal
SNYK-JS-TAR-15032660
  693  
medium severity Prototype Pollution
SNYK-JS-LODASH-15053838
  631  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Prototype Pollution
🦉 Directory Traversal

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request automates a critical security update for the @storybook/builder-webpack5 dependency within the preact-webpack5 framework. The primary goal is to mitigate known vulnerabilities, specifically Directory Traversal and Prototype Pollution, by upgrading the package to a secure version. This ensures the project maintains a robust security posture against common supply chain attacks.

Highlights

  • Security Upgrade: Upgraded the @storybook/builder-webpack5 dependency from 0.0.0-use.local to 7.1.0 to address two medium-severity vulnerabilities: Directory Traversal (SNYK-JS-TAR-15032660) and Prototype Pollution (SNYK-JS-LODASH-15053838).
  • Automated Fix: This pull request was automatically generated by Snyk to apply the necessary security fixes.
  • Yarn Zero-Installs Note: Users leveraging Yarn's zero-installs feature will need to manually run yarn to update the .yarn/cache/ directory, as this PR does not automatically update it.
  • Manual yarn.lock Update Required: The yarn.lock file failed to update automatically and requires manual intervention before merging to ensure dependency consistency.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, aims to fix security vulnerabilities by upgrading @storybook/builder-webpack5. However, the proposed change incorrectly modifies a yarn workspace dependency from workspace:* to a pinned version 7.1.0. This breaks the monorepo's dependency structure by forcing the use of a published, older version from npm instead of the local workspace package. This is a critical issue that will likely lead to build failures and inconsistencies. I have recommended reverting this change. The vulnerabilities should be addressed within the @storybook/builder-webpack5 package or its dependencies directly.

},
"dependencies": {
"@storybook/builder-webpack5": "workspace:*",
"@storybook/builder-webpack5": "7.1.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change replaces the yarn workspace dependency workspace:* with a pinned version 7.1.0. In a monorepo setup, this is incorrect as it will cause yarn to fetch @storybook/builder-webpack5 from the npm registry instead of using the local package from code/builders/builder-webpack5. This can lead to version mismatches, build failures, and unexpected behavior. The version in the workspace is 8.3.0-beta.3, so this is also a significant downgrade. The dependency should be reverted to workspace:* to maintain the integrity of the monorepo's dependency graph. The underlying vulnerabilities should be addressed in the @storybook/builder-webpack5 package itself.

Suggested change
"@storybook/builder-webpack5": "7.1.0",
"@storybook/builder-webpack5": "workspace:*",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants