Skip to content

Conversation

@q1blue
Copy link

@q1blue q1blue commented Jan 29, 2026

snyk-top-banner

Snyk has created this PR to fix 3 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • code/frameworks/server-webpack5/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Directory Traversal
SNYK-JS-TAR-15032660
  149  
medium severity Directory Traversal
SNYK-JS-TAR-15127355
  129  
medium severity Prototype Pollution
SNYK-JS-LODASH-15053838
  87  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Prototype Pollution
🦉 Directory Traversal

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the project's security posture by updating a critical dependency. The upgrade targets specific versions to remediate identified medium-severity vulnerabilities, ensuring a more secure development environment and mitigating potential risks.

Highlights

  • Dependency Upgrade: Upgraded the @storybook/builder-webpack5 dependency from 0.0.0-use.local to 7.1.0.
  • Vulnerability Fixes: This upgrade resolves three medium-severity vulnerabilities: two Directory Traversal issues (SNYK-JS-TAR-15032660, SNYK-JS-TAR-15127355) and one Prototype Pollution issue (SNYK-JS-LODASH-15053838).
  • Manual Intervention Required: The yarn.lock file was not automatically updated and requires manual intervention before merging to ensure consistency with the package.json changes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, aims to fix security vulnerabilities by upgrading @storybook/builder-webpack5. However, the proposed change of pinning the version to 7.1.0 in package.json is incorrect for this monorepo setup. It replaces a workspace:* dependency, which breaks the internal package linkage and attempts to use an older version than what is present in the workspace. This is a critical issue that will likely cause build or runtime problems. The change should be reverted, and the vulnerabilities should be addressed in a way that respects the monorepo's structure.

},
"dependencies": {
"@storybook/builder-webpack5": "workspace:*",
"@storybook/builder-webpack5": "7.1.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly replaces a yarn workspace dependency (workspace:*) with a pinned, older version (7.1.0). This breaks the monorepo's internal dependency structure, which is designed to use the version of @storybook/builder-webpack5 from within this same repository (currently 8.3.0-beta.3).

Using an older, published version will likely lead to build failures or runtime incompatibilities with other Storybook packages in the monorepo that expect a version compatible with the workspace.

While the intent is to fix security vulnerabilities, this approach is incorrect. The vulnerabilities should be addressed within the @storybook/builder-webpack5 package itself or by updating the yarn.lock file with resolutions, without breaking the workspace linkage.

    "@storybook/builder-webpack5": "workspace:*"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants