-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Fix for 4 vulnerabilities #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15032660 - https://snyk.io/vuln/SNYK-JS-TAR-15127355 - https://snyk.io/vuln/SNYK-JS-NEXT-15104645 - https://snyk.io/vuln/SNYK-JS-ESLINT-15102420
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the project's security posture by upgrading several core dependencies. The updates resolve four distinct vulnerabilities, ranging from directory traversal to resource allocation issues. Reviewers should note the critical requirement to manually update the yarn.lock file after these changes are applied. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, aims to fix four vulnerabilities by upgrading several dependencies. While the intent is good, there are critical issues that need to be addressed before merging.
Most importantly, as noted in the PR description, the yarn.lock file has not been updated. This is a required step to ensure the dependency changes are correctly applied and must be done before merging.
Additionally, this PR introduces significant and likely breaking downgrades for @storybook/angular and @storybook/nextjs, changing them from workspace-linked versions to much older, fixed versions. These changes are highly suspect, likely to break the project, and should be reverted in favor of a more targeted fix, such as using yarn's resolutions feature.
Finally, the upgrade of eslint to a new major version (v9) will likely require configuration changes. Please review the ESLint migration guide to ensure a smooth transition.
| "@storybook/addon-toolbars": "workspace:*", | ||
| "@storybook/addon-viewport": "workspace:*", | ||
| "@storybook/angular": "workspace:*", | ||
| "@storybook/angular": "3.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change downgrades @storybook/angular from a workspace-linked version (which resolves to ~8.3.0-beta.3) to a much older version 3.3.0. This is a significant downgrade that will almost certainly introduce breaking changes and is likely an incorrect resolution by Snyk for vulnerabilities in transitive dependencies like tar.
Instead of downgrading this package, the underlying vulnerability should be addressed directly, for instance by adding a resolution for the vulnerable package in package.json. For example, to fix the tar vulnerabilities, you could add:
"resolutions": {
"tar": ">=6.2.1"
}I recommend reverting this change and applying a more targeted fix.
| "@storybook/instrumenter": "workspace:*", | ||
| "@storybook/linter-config": "^4.0.0", | ||
| "@storybook/nextjs": "workspace:*", | ||
| "@storybook/nextjs": "7.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the change for @storybook/angular, this downgrades @storybook/nextjs from a workspace-linked version (~8.3.0-beta.3) to 7.0.0. This is a major downgrade and is likely to cause breakages. This seems to be an incorrect fix from Snyk, probably to address a vulnerability in a transitive dependency.
A better approach would be to add a resolution for the vulnerable package in package.json rather than downgrading @storybook/nextjs. For example, if the vulnerability is in tar, you could add a resolution for it.
I recommend reverting this change and applying a more targeted fix.
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-NEXT-15104645 - https://snyk.io/vuln/SNYK-JS-TAR-15032660 - https://snyk.io/vuln/SNYK-JS-ESLINT-15102420 - https://snyk.io/vuln/SNYK-JS-TAR-15127355
Snyk has created this PR to fix 4 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
code/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15032660
SNYK-JS-TAR-15127355
SNYK-JS-NEXT-15104645
SNYK-JS-ESLINT-15102420
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Allocation of Resources Without Limits or Throttling
🦉 Directory Traversal