-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade @storybook/builder-vite from 0.0.0-use.local to 0.1.22 #372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15032660 - https://snyk.io/vuln/SNYK-JS-TAR-15127355
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the project's security by upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, aims to fix security vulnerabilities by upgrading @storybook/builder-vite. However, the proposed change incorrectly replaces a yarn workspace dependency (workspace:*) with a fixed, old version (0.1.22). This breaks the monorepo's internal dependency structure and will likely lead to build failures or runtime issues. The correct approach is to address the vulnerability within the local @storybook/builder-vite package, not by pinning to an external, outdated version. I have recommended reverting this change.
| "@joshwooding/vite-plugin-react-docgen-typescript": "0.3.1", | ||
| "@rollup/pluginutils": "^5.0.2", | ||
| "@storybook/builder-vite": "workspace:*", | ||
| "@storybook/builder-vite": "0.1.22", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change replaces the internal workspace dependency (workspace:*) with a specific, old version (0.1.22) from the public registry. This breaks the monorepo's dependency management and is likely to cause issues.
The workspace:* protocol ensures that you are using the version of @storybook/builder-vite that is present in this repository (version 8.3.0-beta.3), not a published one. Pinning to 0.1.22 will pull a very old version and likely break compatibility with other packages in the monorepo.
To fix the underlying security vulnerability, the dependencies of the local @storybook/builder-vite package should be updated, rather than changing how it's referenced here. This change should be reverted.
| "@storybook/builder-vite": "0.1.22", | |
| "@storybook/builder-vite": "workspace:*", |
Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
code/frameworks/react-vite/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15032660
SNYK-JS-TAR-15127355
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Directory Traversal