-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade @storybook/builder-webpack5 from 0.0.0-use.local to 7.1.0 #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
…ties The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15032660 - https://snyk.io/vuln/SNYK-JS-TAR-15127355
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to bolster the project's security by updating a key dependency. The primary objective is to resolve identified vulnerabilities, thereby enhancing the overall resilience and safety of the application against potential security exploits. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, aims to fix two security vulnerabilities by modifying a dependency. However, the proposed change of pinning @storybook/builder-webpack5 to 7.1.0 is problematic. It replaces the workspace:* protocol, effectively downgrading the package from the workspace version 8.3.0-beta.3 and breaking the monorepo's intended dependency structure. This is likely to cause build failures or inconsistencies. I've added a critical review comment suggesting to revert this change and instead address the vulnerability by updating the lockfile, as also hinted at in the PR description.
| }, | ||
| "dependencies": { | ||
| "@storybook/builder-webpack5": "workspace:*", | ||
| "@storybook/builder-webpack5": "7.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change replaces the workspace:* protocol with a pinned version 7.1.0 for @storybook/builder-webpack5. This is a significant downgrade from the version 8.3.0-beta.3 provided by the workspace (see code/builders/builder-webpack5/package.json) and breaks the monorepo's dependency management strategy. This will likely introduce build errors or runtime inconsistencies by using an outdated version of the package instead of the one from the local workspace.
To resolve the security vulnerabilities correctly, you should update the yarn.lock file to use a patched version of the transitive dependency (tar). This can be done by running yarn at the root of the monorepo or by using a resolutions field in the root package.json.
| "@storybook/builder-webpack5": "7.1.0", | |
| "@storybook/builder-webpack5": "workspace:*", |
Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
code/frameworks/html-webpack5/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15032660
SNYK-JS-TAR-15127355
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Directory Traversal