Skip to content

Conversation

@q1blue
Copy link

@q1blue q1blue commented Jan 31, 2026

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • code/frameworks/html-webpack5/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Directory Traversal
SNYK-JS-TAR-15032660
  693  
medium severity Directory Traversal
SNYK-JS-TAR-15127355
  596  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Directory Traversal

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to bolster the project's security by updating a key dependency. The primary objective is to resolve identified vulnerabilities, thereby enhancing the overall resilience and safety of the application against potential security exploits.

Highlights

  • Security Upgrade: This pull request upgrades the @storybook/builder-webpack5 dependency from 0.0.0-use.local to 7.1.0 to address two medium-severity Directory Traversal vulnerabilities (SNYK-JS-TAR-15032660 and SNYK-JS-TAR-15127355).
  • Dependency Management: The package.json file has been updated, but the yarn.lock file requires manual intervention as Snyk was unable to update it automatically. This is particularly important for projects utilizing Yarn's zero-install feature.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, aims to fix two security vulnerabilities by modifying a dependency. However, the proposed change of pinning @storybook/builder-webpack5 to 7.1.0 is problematic. It replaces the workspace:* protocol, effectively downgrading the package from the workspace version 8.3.0-beta.3 and breaking the monorepo's intended dependency structure. This is likely to cause build failures or inconsistencies. I've added a critical review comment suggesting to revert this change and instead address the vulnerability by updating the lockfile, as also hinted at in the PR description.

},
"dependencies": {
"@storybook/builder-webpack5": "workspace:*",
"@storybook/builder-webpack5": "7.1.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change replaces the workspace:* protocol with a pinned version 7.1.0 for @storybook/builder-webpack5. This is a significant downgrade from the version 8.3.0-beta.3 provided by the workspace (see code/builders/builder-webpack5/package.json) and breaks the monorepo's dependency management strategy. This will likely introduce build errors or runtime inconsistencies by using an outdated version of the package instead of the one from the local workspace.

To resolve the security vulnerabilities correctly, you should update the yarn.lock file to use a patched version of the transitive dependency (tar). This can be done by running yarn at the root of the monorepo or by using a resolutions field in the root package.json.

Suggested change
"@storybook/builder-webpack5": "7.1.0",
"@storybook/builder-webpack5": "workspace:*",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants