Skip to content

Fix php 8.4 deprecation notices #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devanych merged 1 commit into from
Nov 25, 2024
Merged

Fix php 8.4 deprecation notices #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/ServerRequestCreator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ final class ServerRequestCreator
* @param ServerNormalizerInterface|null $normalizer
* @return ServerRequestInterface
*/
public static function create(ServerNormalizerInterface $normalizer = null): ServerRequestInterface
public static function create(?ServerNormalizerInterface $normalizer = null): ServerRequestInterface
{
return self::createFromGlobals(null, null, null, null, null, $normalizer);
}
Expand All @@ -28,12 +28,12 @@ public static function create(ServerNormalizerInterface $normalizer = null): Ser
* @return ServerRequestInterface
*/
public static function createFromGlobals(
array $server = null,
array $files = null,
array $cookie = null,
array $get = null,
array $post = null,
ServerNormalizerInterface $normalizer = null
?array $server = null,
?array $files = null,
?array $cookie = null,
?array $get = null,
?array $post = null,
?ServerNormalizerInterface $normalizer = null
): ServerRequestInterface {
$server ??= $_SERVER;
$normalizer ??= new SapiNormalizer();
Expand Down
4 changes: 2 additions & 2 deletions src/UploadedFileCreator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ public static function create(
$streamOrFile,
int $size,
int $error,
string $clientFilename = null,
string $clientMediaType = null
?string $clientFilename = null,
?string $clientMediaType = null
): UploadedFileInterface {
return new UploadedFile($streamOrFile, $size, $error, $clientFilename, $clientMediaType);
}
Expand Down
Loading