Skip to content

[attention backends] change to updated repo and version.#13161

Open
sayakpaul wants to merge 2 commits intomainfrom
update-kernel-hub-repos
Open

[attention backends] change to updated repo and version.#13161
sayakpaul wants to merge 2 commits intomainfrom
update-kernel-hub-repos

Conversation

@sayakpaul
Copy link
Member

What does this PR do?

For standardization.

@danieldk @drbh could you advise the revision we should use in diffusers for the attention backends? I have only changed the FA3 one in this PR.

@sayakpaul sayakpaul requested a review from DN6 February 18, 2026 18:17
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

# TODO: temporary revision for now. Remove when merged upstream into `main`.
AttentionBackendName._FLASH_3_HUB: _HubKernelConfig(
repo_id="kernels-community/flash-attn3", function_attr="flash_attn_func", revision="fake-ops-return-probs"
repo_id="kernels-community/flash-attn3", function_attr="flash_attn_func", revision="v1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
repo_id="kernels-community/flash-attn3", function_attr="flash_attn_func", revision="v1"
repo_id="kernels-community/flash-attn3", function_attr="flash_attn_func", version=1

with kernels >= 0.12

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we then asking the users to always keep kernels to >=0.12? Personally, I don't have a problem with it, just want to make sure we're on the same page.

),
AttentionBackendName.SAGE_HUB: _HubKernelConfig(
repo_id="kernels-community/sage_attention", function_attr="sageattn", revision=None
repo_id="kernels-community/sage-attention", function_attr="sageattn", revision=None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MekkCyber, I also think version=1 here?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments