feat(alerts): add scheduleStartAt + scheduleOffsetMinutes by mlsalcedo · Pull Request #1745 · hyperdxio/hyperdx

mlsalcedo · 2026-02-17T14:11:07Z

Closes #1715

Summary

Add scheduleStartAt and scheduleOffsetMinutes to alert schemas and API validation.
Update alert evaluation scheduling to anchor windows by scheduleStartAt when set.
Skip evaluations before scheduleStartAt.
Keep current behavior unchanged when scheduling fields are unset.
Add UI fields and API/OpenAPI/external API support for the new schedule options.
Add alert scheduler tests for anchored windows and pre-start skip behavior.

Notes

This enables Splunk-style scheduled monitor migration where checks must run on isolated, periodic windows anchored to specific times.
scheduleStartAt is the primary anchor; scheduleOffsetMinutes remains optional for backward-compatible alignment.

…n alert scheduling and validation

vercel · 2026-02-17T14:11:12Z

@melsalcedo is attempting to deploy a commit to the HyperDX Team on Vercel.

A member of the Team first needs to authorize it.

changeset-bot · 2026-02-17T14:11:16Z

🦋 Changeset detected

Latest commit: 05b8f25

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
@hyperdx/api	Minor
@hyperdx/app	Minor
@hyperdx/common-utils	Minor
@hyperdx/otel-collector	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

sgarfinkel

Left some feedback

packages/api/src/controllers/alerts.ts

packages/api/src/models/alert.ts

packages/api/src/tasks/checkAlerts/index.ts

Co-authored-by: Sam Garfinkel <10210461+sgarfinkel@users.noreply.github.com>

…unction

…on and controller handling

packages/app/src/DBSearchPageAlertModal.tsx

github-actions · 2026-02-19T21:50:14Z

PR Review: feat(alerts): add scheduleStartAt + scheduleOffsetMinutes

No critical issues found. Implementation is well-structured with solid test coverage.

A few items worth noting:

WARNING: validateAlertScheduleOffsetMinutes skips offset validation when scheduleStartAt is set — The check scheduleOffsetMinutes >= intervalMinutes still runs even when scheduleStartAt is provided (though it correctly does nothing at that point since offset is forced to 0). Not a bug, just a minor clarity issue.
WARNING: Date range limits use approximate year lengths (365 * 24 * 60 * 60 * 1000) — won't account for leap years. Negligible in practice but worth noting.
INFO: Redundant max(1439) on base Zod schema in zod.ts and types.ts — the superRefine already enforces the dynamic per-interval max. Not harmful, just redundant.
INFO: makeAlert calls new Date(alert.scheduleStartAt) without error handling — safe because alertSchema.parse() is now called before makeAlert in all routers, ensuring scheduleStartAt is a valid ISO string. The recent change to explicitly parse in routers (previously req.body was used directly) is a good fix.

The backward-compat strategy via normalizeNoOpAlertScheduleFields and the null-vs-undefined distinction for scheduleStartAt serialization are well thought out.

Reviewed by Claude Sonnet 4.6

…arttime-offset # Conflicts: # packages/api/src/utils/zod.ts # packages/app/src/DBSearchPageAlertModal.tsx # packages/app/src/components/DBEditTimeChartForm.tsx

Wrap scheduling settings (start offset and anchor start time) in a collapsible section that auto-expands when the user has configured non-default values. Adds inline description and tooltip help text for each field. Made-with: Cursor

teeohhem

things I added

Advanced Settings collapsable menu for these new fields, along with text descriptions and tooltips.
Date format in the timepicker to match the rest of the application.

…arttime-offset

…issue-1715-starttime-offset # Conflicts: # packages/app/src/components/AlertScheduleFields.tsx

github-actions · 2026-03-03T01:52:48Z

Claude finished @mlsalcedo's task in 2m 59s —— View job

Code Review

Gather context and read changed files
Analyze for critical issues
Post review

Review

Previous critical issues from the last review have been resolved:

✅ Schema chain fixed — alertSchema in zod.ts now correctly chains .and(zSavedSearchAlert.or(zTileAlert)).superRefine(validateAlertScheduleOffsetMinutes). The savedSearchId/dashboardId/tileId discriminator validation is no longer a dead no-op.
✅ (alert as any) casts removed from DBEditTimeChartForm.tsx
✅ Silent offset-0 drop fixed — normalizeNoOpAlertScheduleFields now uses dirtyFields.alert?.scheduleOffsetMinutes as preserveExplicitScheduleOffsetMinutes consistently in both DBSearchPageAlertModal and DBEditTimeChartForm

Remaining items:

⚠️ Double-parse overhead (packages/api/src/routers/api/alerts.ts:103, packages/api/src/routers/external-api/v2/alerts.ts:419, 511) — alertSchema.parse(req.body) is called again inside the handler after validateRequest middleware already ran it. The comment explains the rationale (enforce refinements, strip unknown fields). This is safe but adds redundant work on every request; consider a shared parsed-body approach if this becomes a perf concern.
ℹ️ name / message omitted from internal GET /api/alerts list (packages/api/src/routers/api/alerts.ts:67–79) — the _.pick doesn't include name or message. Pre-existing omission, not introduced by this PR.
ℹ️ AlertScheduleFields accordion opened state (packages/app/src/components/AlertScheduleFields.tsx:58) — useState(hasAdvancedScheduleValues) captures the initial value only. If a parent re-renders with a different scheduleOffsetMinutes/scheduleStartAt, the accordion won't auto-open. Acceptable for current UX since initial form values are set correctly on mount.

✅ No blocking issues. Implementation is solid — backward-compat strategy, validation chain, and scheduler window logic are all correct.

mlsalcedo · 2026-03-03T01:52:49Z

Advanced Settings collapsable menu for these new fields, along with text descriptions and tooltips.

Date format in the timepicker to match the rest of the application.

Done

github-actions · 2026-03-03T01:59:46Z

Claude finished @mlsalcedo's task in 1m 37s —— View job

Code Review

Gather context and read changed files
Analyze for critical issues
Post review

Review

Previous critical issues have been resolved. The implementation looks solid — schema chain, type safety, and backward-compat strategy are all correct.

A few remaining items:

⚠️ scheduleStartAt: null stored explicitly in MongoDB (packages/api/src/models/alert.ts) — When a user clears scheduleStartAt, null is persisted to the document (vs. the key being absent on pre-migration alerts). checkAlerts handles this correctly via scheduleStartAt == null, but any future queries filtering { scheduleStartAt: { $exists: false } } would miss these documents. Low risk now, worth noting for migrations.
⚠️ getScheduledWindowStart exported but has no test for scheduleOffsetMinutes > 0 with anchored start (packages/api/src/tasks/checkAlerts/index.ts:113) — The function logs that offset is ignored when scheduleStartAt is set, but there's no unit test confirming scheduleOffsetMinutes is actually ignored in the return value. The processAlert path normalizes this, but getScheduledWindowStart itself doesn't enforce it.
ℹ️ processRequest vs validateRequest switch (packages/api/src/routers/api/alerts.ts, external-api/v2/alerts.ts) — Good change. processRequest replaces req.body with the parsed+stripped result, enforcing refinements (including superRefine) where validateRequest did not. The behavior change is intentional and correct.
ℹ️ useState(hasAdvancedScheduleValues) initial capture (packages/app/src/components/AlertScheduleFields.tsx:58) — Pre-existing from previous review: accordion won't auto-open if parent re-renders with new schedule values post-mount. Acceptable for current UX.

✅ No blocking issues. Ready to merge pending reviewer approval.

…arttime-offset # Conflicts: # packages/api/src/routers/api/__tests__/alerts.test.ts # packages/api/src/routers/api/alerts.ts # packages/api/src/routers/external-api/v2/alerts.ts

github-actions · 2026-03-03T22:32:35Z

Claude finished @mlsalcedo's task in 1m 37s —— View job

Code Review

Gather context and read changed files
Analyze for critical issues
Post review

Review

All critical issues from previous reviews have been resolved. The implementation is solid — schema chain, type safety, backward-compat strategy, and scheduler window logic are correct.

Remaining items (carry-overs from prior reviews):

⚠️ getScheduledWindowStart accepts scheduleOffsetMinutes even when scheduleStartAt is set (packages/api/src/tasks/checkAlerts/index.ts:249–271) — the function itself doesn't drop the offset; only processAlert enforces the ignore-behavior. If called directly with both params, it silently applies offset anyway. No test confirms offset is ignored at the return-value level. Low risk since callers normalize, but a comment or assertion inside the function would help.
ℹ️ scheduleStartAt: null written explicitly to MongoDB on clear (packages/api/src/models/alert.ts) — future queries using { $exists: false } would miss these docs. Pre-migration alerts use key-absent, post-clear alerts use null. Consider coercing to key-absent on read/write if this becomes a migration concern.
ℹ️ useState(hasAdvancedScheduleValues) captures initial value only (packages/app/src/components/AlertScheduleFields.tsx:58) — accordion won't auto-open if parent passes new schedule values post-mount. Acceptable for the current UX since initial form values are set correctly.

✅ No blocking issues. Ready to merge pending reviewer approval.

teeohhem · 2026-03-04T19:53:49Z

@claude please review and fix the conflicts

github-actions · 2026-03-04T19:55:04Z

Claude Code is working…

I'll analyze this and get back to you.

View job run

…arttime-offset # Conflicts: # packages/api/src/tasks/checkAlerts/__tests__/checkAlerts.test.ts # packages/api/src/tasks/checkAlerts/index.ts

github-actions · 2026-03-04T20:24:23Z

Claude finished @mlsalcedo's task in 1m 36s —— View job

Code Review

Check for merge conflicts
Review code for critical issues

Conflict Status

The conflicts previously flagged by GitHub were already resolved in merge commit d1c329a5 ("Merge remote-tracking branch 'upstream/main' into codex/issue-1715-starttime-offset"). The branch is fully up-to-date with origin/main — no pending conflicts remain.

The conflict resolution in checkAlerts/index.ts and checkAlerts/__tests__/checkAlerts.test.ts correctly integrates both the new scheduling logic (getScheduledWindowStart, alertHasGroupBy, scheduleStartAt pre-skip) and the upstream whereLanguage fixes for tile alerts.

Review

✅ No critical issues. The implementation is solid and previous review blockers have all been addressed.

One carry-over worth noting before merge:

⚠️ getScheduledWindowStart doesn't enforce offset=0 when scheduleStartAt is set (packages/api/src/tasks/checkAlerts/index.ts:150–168) — the function accepts both params but only processAlert enforces the ignore-behavior via a log warning. If called directly with both, offset is silently applied. A guard or comment inside the function would prevent future misuse. Fix this →

github-actions · 2026-03-04T22:55:19Z

Claude finished @mlsalcedo's task in 37s —— View job

Code Review

Read changed files
Analyze for critical issues
Post review

Review

All previously flagged critical issues have been resolved. The implementation looks correct.

One minor carry-over worth noting:

⚠️ getScheduledWindowStart silently accepts scheduleOffsetMinutes when scheduleStartAt is set (packages/api/src/tasks/checkAlerts/index.ts:148–169) — if called directly with both params, offset is applied anyway; only processAlert enforces ignore-behavior. A guard or comment inside the function would prevent future misuse. Fix this →

✅ No blocking issues. Ready to merge pending reviewer approval.

…arttime-offset # Conflicts: # packages/app/src/components/DBEditTimeChartForm.tsx # packages/common-utils/src/types.ts

… into codex/issue-1715-starttime-offset

github-actions · 2026-03-05T21:14:31Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

github-actions · 2026-03-05T22:38:16Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

teeohhem · 2026-03-06T01:47:09Z

@mlsalcedo thanks for your contribution and sticking with all the conflicts/changes.

feat: add support for scheduleStartAt and scheduleOffsetMinutes i…

c1b8292

…n alert scheduling and validation

sgarfinkel reviewed Feb 17, 2026

View reviewed changes

mlsalcedo and others added 4 commits February 17, 2026 10:36

Update packages/api/src/controllers/alerts.ts

ffa5bf2

Co-authored-by: Sam Garfinkel <10210461+sgarfinkel@users.noreply.github.com>

Update packages/api/src/controllers/alerts.ts

7f1506c

Co-authored-by: Sam Garfinkel <10210461+sgarfinkel@users.noreply.github.com>

refactor: simplify scheduleStartAt validation using fns.isValid f…

8408688

…unction

feat: improve alert scheduling by updating scheduleStartAt validati…

bf4b847

…on and controller handling

teeohhem self-requested a review February 19, 2026 18:09

teeohhem reviewed Feb 19, 2026

View reviewed changes

packages/app/src/DBSearchPageAlertModal.tsx Show resolved Hide resolved

Merge branch 'main' into startTime-offset

799c84c

melsalcedo added 11 commits February 19, 2026 18:01

refactor(alerts): dedupe interval and offset validation

03c07cb

feat(app): use DateTimePicker for scheduleStartAt input

f8b379e

feat(app): add datetime picker to dashboard alert start time

ea4ab24

refactor(alerts): share scheduleStartAt schema and parser

dfadc7e

chore(alerts): clarify anchor start label in forms

b903e61

fix(alerts): handle null scheduleStartAt and add scheduling guards

d1a028d

chore(alerts): address review feedback for schedule start

29af34b

chore(alerts): normalize schedule defaults and 1m offset UX

30c4865

refactor(alerts): centralize schedule fields and harden API validation

32a7267

fix(alerts): avoid no-op schedule writes for existing alerts

539b531

refactor(alerts): share no-op schedule normalization helper

41e0c26

mlsalcedo requested review from sgarfinkel and teeohhem February 20, 2026 07:46

melsalcedo added 5 commits February 20, 2026 02:56

fix(alerts): tighten scheduleStartAt validation and defaults

6e31044

fix(alerts): guard new-alert schedule normalization

d1498fc

chore(alerts): tighten copy and offset bounds

fe52938

chore(alerts): clarify offset behavior with anchored start

f7cceef

chore(alerts): guard anchor bounds and document zod coupling

6a4c407

melsalcedo and others added 4 commits February 27, 2026 19:13

fix(app): preserve explicit alert schedule resets

64052ab

Merge remote-tracking branch 'upstream/main' into codex/issue-1715-st…

da9293d

…arttime-offset # Conflicts: # packages/api/src/utils/zod.ts # packages/app/src/DBSearchPageAlertModal.tsx # packages/app/src/components/DBEditTimeChartForm.tsx

test(api): cover omitted alert schedule updates

2f3c582

teeohhem reviewed Mar 2, 2026

View reviewed changes

melsalcedo added 4 commits March 2, 2026 20:28

Merge remote-tracking branch 'upstream/main' into codex/issue-1715-st…

2505234

…arttime-offset

feat(app): tuck alert scheduling under advanced settings

4d199db

Merge remote-tracking branch 'mlsalcedo/startTime-offset' into codex/…

a9c3a0a

…issue-1715-starttime-offset # Conflicts: # packages/app/src/components/AlertScheduleFields.tsx

refactor(app): align alert schedule layouts

436adb8

refactor(api): parse alert requests in middleware

3acb031

Merge remote-tracking branch 'upstream/main' into codex/issue-1715-st…

b4928d7

…arttime-offset # Conflicts: # packages/api/src/routers/api/__tests__/alerts.test.ts # packages/api/src/routers/api/alerts.ts # packages/api/src/routers/external-api/v2/alerts.ts

Merge remote-tracking branch 'upstream/main' into codex/issue-1715-st…

d1c329a

…arttime-offset # Conflicts: # packages/api/src/tasks/checkAlerts/__tests__/checkAlerts.test.ts # packages/api/src/tasks/checkAlerts/index.ts

Merge branch 'main' into startTime-offset

04efb18

melsalcedo added 2 commits March 5, 2026 16:13

Merge remote-tracking branch 'upstream/main' into codex/issue-1715-st…

b1faed3

…arttime-offset # Conflicts: # packages/app/src/components/DBEditTimeChartForm.tsx # packages/common-utils/src/types.ts

Merge branch 'startTime-offset' of https://github.com/mlsalcedo/hyperdx…

d302304

… into codex/issue-1715-starttime-offset

fix: linitng

05b8f25

teeohhem added the automerge label Mar 6, 2026

teeohhem approved these changes Mar 6, 2026

View reviewed changes

kodiakhq bot merged commit 902b8eb into hyperdxio:main Mar 6, 2026
14 of 25 checks passed

Conversation

mlsalcedo commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Notes

Uh oh!

vercel bot commented Feb 17, 2026

Uh oh!

changeset-bot bot commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

sgarfinkel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review: feat(alerts): add scheduleStartAt + scheduleOffsetMinutes

Uh oh!

teeohhem left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review

Review

Uh oh!

mlsalcedo commented Mar 3, 2026

Uh oh!

github-actions bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review

Review

Uh oh!

github-actions bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review

Review

Uh oh!

teeohhem commented Mar 4, 2026

Uh oh!

github-actions bot commented Mar 4, 2026

Uh oh!

github-actions bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review

Conflict Status

Review

Uh oh!

github-actions bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review

Review

Uh oh!

github-actions bot commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

teeohhem commented Mar 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mlsalcedo commented Feb 17, 2026 •

edited

Loading

changeset-bot bot commented Feb 17, 2026 •

edited

Loading

github-actions bot commented Feb 19, 2026 •

edited

Loading

github-actions bot commented Mar 3, 2026 •

edited

Loading

github-actions bot commented Mar 3, 2026 •

edited

Loading

github-actions bot commented Mar 3, 2026 •

edited

Loading

github-actions bot commented Mar 4, 2026 •

edited

Loading

github-actions bot commented Mar 4, 2026 •

edited

Loading

github-actions bot commented Mar 5, 2026 •

edited

Loading

github-actions bot commented Mar 5, 2026 •

edited

Loading